RE: PL/SQL coding style

From: Koivu, Lisa <lkoivu_at_qode.com>
Date: Thu, 18 Jan 2001 12:16:20 -0500
Message-Id: <10745.127023@fatcity.com>

This message is in MIME format. Since your mail reader does not understand this format, some or all of this message may not be legible.

------_=_NextPart_001_01C08172.63C3882C
Content-Type: text/plain;

charset="iso-8859-1"

Chandini,

GOTOS are ABSOLUTE VOODOO. He thinks that SELECT INTO is more readable, how readable is a GOTO?? It ISN'T. Good style also involves writing code that does not involve UNNECESSARY PROCESSING.

Give him Feuernstein's book. That's correct style in my opinion that is not recreating the wheel and utilizing all that PL/SQL does for you.

I almost liken not using exception handling to not using the classes that are given to you in java.

But seriously, I've been in the same position. Being the dba, all code that is compiled into the database is my responsibility. When I came here, I screamed bloody murder because exceptions weren't being used, the sqlcode was being passed all over the place instead. I insisted on changes to the standards document to enforce use of exceptions plus educated some of the developers on how to use them. The bottom line is, if you support it, then you give the final yay or nay for the code.

Of course, you could be direct and just tell him to pull his head out.

HTH
Lisa

-----Original Message-----
From: Chandini Paterson [mailto:chandini.paterson_at_morse.com] Sent: Thursday, January 18, 2001 11:02 AM To: Multiple recipients of list ORACLE-L Subject: PL/SQL coding style

Hi gurus,
  I've just changed jobs quite recently and am already having problems with my Senior Developer (yippee)
  It concerns the PL/SQL coding style. The guy insists that I use 'SELECT ..INTO ' in my code rather than explicit cursors, even though I tried telling him it is more efficient with the latter. He apparently finds it more 'readable' with the 'SELECT.. INTO ' and says that the double fetch
(for each row) is 'no big deal'.

  Also, he insists of using a lot of GOTOs in his code and expects me to do the same. I am adamant that we use EXCEPTION handlers to achieve the same thing (BAsically he checks for error conditions in his code and then does a 'goto error_handler' to handle the error!!!). I prefer using EXCEPTIONS to handle all my error conditions.
  I was just wondering if my concepts are all wrong at this time. I am just curious to know if any of you find his way of coding style preferable to mine. (OH, by the way, he was initially a 'C' progrmmer). Any inputs will be greatly appreciated.

Thanks
Chandini

-- 
Please see the official ORACLE-L FAQ: http://www.orafaq.com
-- 
Author: Chandini Paterson
  INET: chandini.paterson_at_morse.com

Fat City Network Services    -- (858) 538-5051  FAX: (858) 538-5051
San Diego, California        -- Public Internet access / Mailing Lists
--------------------------------------------------------------------
To REMOVE yourself from this mailing list, send an E-Mail message
to: ListGuru_at_fatcity.com (note EXACT spelling of 'ListGuru') and in
the message BODY, include a line containing: UNSUB ORACLE-L


(or the name of mailing list you want to be removed from).  You may

also send the HELP command for other information (like subscribing).

------_=_NextPart_001_01C08172.63C3882C
Content-Type: text/html;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV=3D"Content-Type" CONTENT=3D"text/html; =
charset=3Diso-8859-1">
<META NAME=3D"Generator" CONTENT=3D"MS Exchange Server version =
5.5.2650.12">
<TITLE>RE: PL/SQL  coding style</TITLE>
</HEAD>
<BODY>

<P><FONT SIZE=3D2>Chandini, </FONT>
</P>

<P><FONT SIZE=3D2>GOTOS are ABSOLUTE VOODOO.&nbsp; He thinks that =
SELECT INTO is more readable, how readable is a GOTO??&nbsp; It =
ISN'T.&nbsp; Good style also involves writing code that does not =
involve UNNECESSARY PROCESSING.&nbsp; </FONT></P>

<P><FONT SIZE=3D2>Give him Feuernstein's book.&nbsp; That's correct =
style in my opinion that is not recreating the wheel and utilizing all =
that PL/SQL does for you. </FONT></P>

<P><FONT SIZE=3D2>I almost liken not using exception handling to not =
using the classes that are given to you in java.&nbsp; </FONT>
</P>

<P><FONT SIZE=3D2>But seriously, I've been in the same position.&nbsp; =
Being the dba, all code that is compiled into the database is my =
responsibility.&nbsp; When I came here, I screamed bloody murder =
because exceptions weren't being used, the sqlcode was being passed all =
over the place instead.&nbsp; I insisted on changes to the standards =
document to enforce use of exceptions plus educated some of the =
developers on how to use them.&nbsp; The bottom line is, if you support =
it, then you give the final yay or nay for the code.&nbsp; </FONT></P>

<P><FONT SIZE=3D2>Of course, you could be direct and just tell him to =
pull his head out. </FONT>
</P>

<P><FONT SIZE=3D2>HTH</FONT>
<BR><FONT SIZE=3D2>Lisa</FONT>
</P>

<P><FONT SIZE=3D2>-----Original Message-----</FONT>
<BR><FONT SIZE=3D2>From: Chandini Paterson [<A =
HREF=3D"mailto:chandini.paterson_at_morse.com">mailto:chandini.paterson_at_mor=
se.com</A>]</FONT>
<BR><FONT SIZE=3D2>Sent: Thursday, January 18, 2001 11:02 AM</FONT>
<BR><FONT SIZE=3D2>To: Multiple recipients of list ORACLE-L</FONT>
<BR><FONT SIZE=3D2>Subject: PL/SQL coding style</FONT>
</P>
<BR>

<P><FONT SIZE=3D2>Hi gurus,</FONT>
<BR><FONT SIZE=3D2>&nbsp; I've just changed jobs quite recently and am =
already having problems with</FONT>
<BR><FONT SIZE=3D2>my Senior Developer (yippee)</FONT>
<BR><FONT SIZE=3D2>&nbsp; It concerns the PL/SQL coding style.&nbsp; =
The guy insists that I use 'SELECT</FONT>
<BR><FONT SIZE=3D2>..INTO ' in my code rather than explicit cursors, =
even though I tried</FONT>
<BR><FONT SIZE=3D2>telling him it is more efficient with the latter. He =
apparently finds it</FONT>
<BR><FONT SIZE=3D2>more 'readable' with the 'SELECT.. INTO ' and says =
that the double fetch</FONT>
<BR><FONT SIZE=3D2>(for each row) is 'no big deal'.</FONT>
<BR><FONT SIZE=3D2>&nbsp; Also, he insists of using a lot of GOTOs in =
his code and expects me to do</FONT>
<BR><FONT SIZE=3D2>the same.&nbsp; I am adamant that we use EXCEPTION =
handlers to achieve the same</FONT>
<BR><FONT SIZE=3D2>thing (BAsically he checks for error conditions in =
his code and then does a</FONT>
<BR><FONT SIZE=3D2>'goto error_handler' to handle the error!!!). I =
prefer using EXCEPTIONS to</FONT>
<BR><FONT SIZE=3D2>handle all my error conditions.</FONT>
<BR><FONT SIZE=3D2>&nbsp; I was just wondering if my concepts are all =
wrong at this time.&nbsp; I am just</FONT>
<BR><FONT SIZE=3D2>curious to know if any of you find his way of coding =
style preferable to</FONT>
<BR><FONT SIZE=3D2>mine. (OH, by the way, he was initially a 'C' =
progrmmer).&nbsp; Any inputs will</FONT>
<BR><FONT SIZE=3D2>be greatly appreciated.</FONT>
</P>

<P><FONT SIZE=3D2>Thanks</FONT>
<BR><FONT SIZE=3D2>Chandini</FONT>
</P>

<P><FONT SIZE=3D2>-- </FONT>
<BR><FONT SIZE=3D2>Please see the official ORACLE-L FAQ: <A =
HREF=3D"http://www.orafaq.com" =
TARGET=3D"_blank">http://www.orafaq.com</A></FONT>
<BR><FONT SIZE=3D2>-- </FONT>
<BR><FONT SIZE=3D2>Author: Chandini Paterson</FONT>
<BR><FONT SIZE=3D2>&nbsp; INET: chandini.paterson_at_morse.com</FONT>
</P>

<P><FONT SIZE=3D2>Fat City Network Services&nbsp;&nbsp;&nbsp; -- (858) =
538-5051&nbsp; FAX: (858) 538-5051</FONT>
<BR><FONT SIZE=3D2>San Diego, =
California&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; -- Public Internet =
access / Mailing Lists</FONT>
<BR><FONT =
SIZE=3D2>---------------------------------------------------------------=
-----</FONT>
<BR><FONT SIZE=3D2>To REMOVE yourself from this mailing list, send an =
E-Mail message</FONT>
<BR><FONT SIZE=3D2>to: ListGuru_at_fatcity.com (note EXACT spelling of =
'ListGuru') and in</FONT>
<BR><FONT SIZE=3D2>the message BODY, include a line containing: UNSUB =
ORACLE-L</FONT>
<BR><FONT SIZE=3D2>(or the name of mailing list you want to be removed =

Received on Thu Jan 18 2001 - 11:16:20 CST